Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @hccheng72, |
microsoft-github-policy-service
Bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Pull request overview
This PR removes the --disk-driver-version flag from the aks-preview extension’s az aks create / az aks update commands, including associated constants, parameter wiring, help text, and test coverage that exercised version selection.
Changes:
- Removed
disk_driver_versionargument plumbing from command parameters and custom command entrypoints. - Simplified
get_disk_driver()logic to only handle enable/disable flows (no version selection). - Updated tests and deleted scenario recordings tied to the removed flag; updated
HISTORY.rst.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/managed_cluster_decorator.py | Removes disk_driver_version handling/validation from disk CSI driver profile generation. |
| src/aks-preview/azext_aks_preview/custom.py | Removes disk_driver_version from aks_create / aks_update function signatures. |
| src/aks-preview/azext_aks_preview/_params.py | Removes --disk-driver-version argument definition and related enum list/imports. |
| src/aks-preview/azext_aks_preview/_help.py | Removes --disk-driver-version from command help entries. |
| src/aks-preview/azext_aks_preview/_consts.py | Removes disk driver version constants (v1/v2). |
| src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py | Removes unit test cases covering disk_driver_version behavior. |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Removes scenario tests/checks that depended on --disk-driver-version / disk driver version assertions. |
| src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_create_with_csi_driver_v2.yaml | Deletes recording for removed scenario test. |
| src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_create_and_update_csi_driver_to_v2.yaml | Deletes recording for removed scenario test. |
| src/aks-preview/HISTORY.rst | Adds changelog entry under Pending for the flag removal. |
|
hccheng72
force-pushed
the
remove-disk-driver-version
branch
from
db39433 to
d0cd20e
Compare
|
/azp run |
| +++++++ | ||
| * `az aks nodepool update`: Support `--node-vm-size` to resize VM size of an existing VMSS-based agent pool (preview). Requires AFEC registration `Microsoft.ContainerService/AgentPoolVMSSResize`. | ||
|
|
||
| 20.0.0b4 |
There was a problem hiding this comment.
This is a breaking change, please update the major version to 21, for example, use a version number such as 21.0.0b1.
|
Azure Pipelines successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create --disk-driver-version
az aks update --disk-driver-version
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.